mmainguy/immersive2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable per-instance edge rendering for hover effects

Browse Source 
Changed EdgesRenderer to work on individual instances instead of source mesh to prevent all instances from highlighting when one is hovered.

- Remove edgesShareWithInstances flag (was causing all instances to highlight)
- Enable/disable edges directly on hovered instance
- Adjust edge width to 0.2 and color to pure white for cleaner appearance
- Remove metadata tracking in favor of checking edgesRenderer directly

This ensures only the specific hovered entity shows visual feedback while maintaining haptic feedback for all interactions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Michael Mainguy 2025-11-13 05:49:54 -06:00
parent 0ad61bdde9
commit d59c7b6e6e
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/diagram/functions/buildEntityActionManager.ts
View File

@ -21,15 +21,11 @@ export function buildEntityActionManager(controllerObservable: Observable<Contro
try {
const mesh = evt.meshUnderPointer as InstancedMesh;
if (mesh.sourceMesh && !mesh.sourceMesh.edgesRenderer) {
// Enable edges rendering on the source mesh
mesh.sourceMesh.enableEdgesRendering(0.99);
mesh.sourceMesh.edgesWidth = 4.0;
mesh.sourceMesh.edgesColor = new Color4(1.5, 1.5, 1.5, 1.0);
// Track that edges are enabled
mesh.metadata = mesh.metadata || {};
mesh.metadata.edgesEnabled = true;
// Enable edges rendering on the instance itself (not source mesh)
if (!mesh.edgesRenderer) {
mesh.enableEdgesRendering(0.99);
mesh.edgesWidth = .2;
mesh.edgesColor = new Color4(1, 1, 1, 1.0);
}
} catch (e) {
logger.error(e);
@ -46,9 +42,9 @@ export function buildEntityActionManager(controllerObservable: Observable<Contro
new ExecuteCodeAction(ActionManager.OnPointerOutTrigger, (evt) => {
try {
const mesh = evt.source as InstancedMesh;
if (mesh.metadata?.edgesEnabled && mesh.sourceMesh?.edgesRenderer) {
mesh.sourceMesh.disableEdgesRendering();
mesh.metadata.edgesEnabled = false;
// Disable edges rendering on the instance itself
if (mesh?.edgesRenderer) {
mesh.disableEdgesRendering();
}
} catch (e) {
logger.error(e);