mmainguy/space-game
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix physics recorder crash when bodies are disposed during capture
All checks were successful
Build / build (push) Successful in 1m31s
Details

Browse Source 
Added defensive checks and try-catch to handle race conditions where physics
bodies are disposed between the filter check and property access. This commonly
happens with projectiles and destroyed asteroids.

Changes:
- Added null/undefined check for physicsBody in filter
- Added transformNode existence check before access
- Wrapped capture logic in try-catch to skip disposed objects
- Continue loop instead of crashing when object is disposed

Fixes TypeError: Cannot read properties of undefined (reading 'transformNode')

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Michael Mainguy 2025-11-08 05:26:37 -06:00
parent 96ae033064
commit e473e3d03e
1 changed files with 57 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

104
src/physicsRecorder.ts
View File

@ -155,61 +155,71 @@ export class PhysicsRecorder {
const objects: PhysicsObjectState[] = [];
// Get all physics-enabled meshes
const physicsMeshes = this._scene.meshes.filter(mesh => mesh.physicsBody !== null);
const physicsMeshes = this._scene.meshes.filter(mesh => mesh.physicsBody !== null && mesh.physicsBody !== undefined);
for (const mesh of physicsMeshes) {
const body = mesh.physicsBody!;
const body = mesh.physicsBody;
// Get position
const pos = body.transformNode.position;
// Get rotation as quaternion
let quat = body.transformNode.rotationQuaternion;
if (!quat) {
// Convert Euler to Quaternion if needed
const rot = body.transformNode.rotation;
quat = Quaternion.FromEulerAngles(rot.x, rot.y, rot.z);
// Double-check body still exists and has transformNode (can be disposed between filter and here)
if (!body || !body.transformNode) {
continue;
}
// Get velocities
const linVel = body.getLinearVelocity();
const angVel = body.getAngularVelocity();
try {
// Get position
const pos = body.transformNode.position;
// Get mass
const mass = body.getMassProperties().mass;
// Get rotation as quaternion
let quat = body.transformNode.rotationQuaternion;
if (!quat) {
// Convert Euler to Quaternion if needed
const rot = body.transformNode.rotation;
quat = Quaternion.FromEulerAngles(rot.x, rot.y, rot.z);
}
// Get restitution (from shape material if available)
let restitution = 0;
if (body.shape && (body.shape as any).material) {
restitution = (body.shape as any).material.restitution || 0;
// Get velocities
const linVel = body.getLinearVelocity();
const angVel = body.getAngularVelocity();
// Get mass
const mass = body.getMassProperties().mass;
// Get restitution (from shape material if available)
let restitution = 0;
if (body.shape && (body.shape as any).material) {
restitution = (body.shape as any).material.restitution || 0;
}
objects.push({
id: mesh.id,
position: [
parseFloat(pos.x.toFixed(3)),
parseFloat(pos.y.toFixed(3)),
parseFloat(pos.z.toFixed(3))
],
rotation: [
parseFloat(quat.x.toFixed(4)),
parseFloat(quat.y.toFixed(4)),
parseFloat(quat.z.toFixed(4)),
parseFloat(quat.w.toFixed(4))
],
linearVelocity: [
parseFloat(linVel.x.toFixed(3)),
parseFloat(linVel.y.toFixed(3)),
parseFloat(linVel.z.toFixed(3))
],
angularVelocity: [
parseFloat(angVel.x.toFixed(3)),
parseFloat(angVel.y.toFixed(3)),
parseFloat(angVel.z.toFixed(3))
],
mass: parseFloat(mass.toFixed(2)),
restitution: parseFloat(restitution.toFixed(2))
});
} catch (error) {
// Physics body was disposed during capture, skip this object
continue;
}
objects.push({
id: mesh.id,
position: [
parseFloat(pos.x.toFixed(3)),
parseFloat(pos.y.toFixed(3)),
parseFloat(pos.z.toFixed(3))
],
rotation: [
parseFloat(quat.x.toFixed(4)),
parseFloat(quat.y.toFixed(4)),
parseFloat(quat.z.toFixed(4)),
parseFloat(quat.w.toFixed(4))
],
linearVelocity: [
parseFloat(linVel.x.toFixed(3)),
parseFloat(linVel.y.toFixed(3)),
parseFloat(linVel.z.toFixed(3))
],
angularVelocity: [
parseFloat(angVel.x.toFixed(3)),
parseFloat(angVel.y.toFixed(3)),
parseFloat(angVel.z.toFixed(3))
],
mass: parseFloat(mass.toFixed(2)),
restitution: parseFloat(restitution.toFixed(2))
});
}
const snapshot: PhysicsSnapshot = {